Skip to content

refactor: fetch github data at build time #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

Conversation

aidan-casey
Copy link
Member

No description provided.

@brendt
Copy link
Member

brendt commented Apr 23, 2025

Should we merge this?

@innocenzi innocenzi changed the title Fix GitHub rate limit refactor: fetch github data at build time May 22, 2025
@innocenzi innocenzi merged commit 0c4a75d into main May 22, 2025
1 of 3 checks passed
@innocenzi innocenzi deleted the fix/github-rate-limit branch May 22, 2025 10:14
@innocenzi
Copy link
Member

I merged, but I think those environment variables are no longer there on subsequent (scheduled) tempest static:generate calls?

@brendt
Copy link
Member

brendt commented May 22, 2025

True, and that command is run every hour. Although, that's not needed anymore, I believe. That was a workaround to fetch up-to-date github data waaaaay back. So we can probably remove it

innocenzi added a commit that referenced this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants